Skip to contentSkip to conversation

Change in openvpn[master]: tapctl: Remove unused function dont_mute

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Apr 5 – Apr 19 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1775421558000.I87c40dc94035345add1162e5029e51288811cb09@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email

to review the following change.

Change subject: tapctl: Remove unused function dont_mute
......................................................................

tapctl: Remove unused function dont_mute

Identified by cppcheck.

Change-Id I87c40dc94035345add1162e5029e51288811cb09

---
M src/tapctl/error.h
M src/tapctl/main.c

2 files changed, 2 insertions(+), 11 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/15/1615/1

src/tapctl/error.h +2 -2
index 9632b2f..f9586dc 100644
@@ -109,11 +109,11 @@
     return (level & M_DEBUG_LEVEL) <= x_debug_level;
 }
 
-/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flags represent */
 static inline bool
 msg_test(unsigned int flags)
 {
-    return check_debug_level(flags) && dont_mute(flags);
+    return check_debug_level(flags);
 }
 
 #endif /* ifndef ERROR_H */
src/tapctl/main.c +0 -9
index 1d047dd..6a4a240 100644
@@ -686,15 +686,6 @@
 }
 
 
-bool
-dont_mute(unsigned int flags)
-{
-    UNREFERENCED_PARAMETER(flags);
-
-    return true;
-}
-
-
 void
 x_msg_va(const unsigned int flags, const char *format, va_list arglist)
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email )

Change subject: tapctl: Remove unused function dont_mute
......................................................................

Patch Set 3: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Sun, 19 Apr 2026 13:39:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#3 lore raw

PATCH v3 1/1 tapctl: Remove unused function dont_mute

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Identified by cppcheck.

Change-Id I87c40dc94035345add1162e5029e51288811cb09

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
This mail reflects revision 3 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

src/tapctl/error.h +2 -2
index 9632b2f..f9586dc 100644
@@ -109,11 +109,11 @@
     return (level & M_DEBUG_LEVEL) <= x_debug_level;
 }
 
-/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flags represent */
 static inline bool
 msg_test(unsigned int flags)
 {
-    return check_debug_level(flags) && dont_mute(flags);
+    return check_debug_level(flags);
 }
 
 #endif /* ifndef ERROR_H */
src/tapctl/main.c +0 -9
index 1d047dd..6a4a240 100644
@@ -686,15 +686,6 @@
 }
 
 
-bool
-dont_mute(unsigned int flags)
-{
-    UNREFERENCED_PARAMETER(flags);
-
-    return true;
-}
-
-
 void
 x_msg_va(const unsigned int flags, const char *format, va_list arglist)
 {
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: tapctl: Remove unused function dont_mute

This was a bit nonintuitive at first ("but it does get used... oh, wait, it's a stub that always returns 'true'"). Well, I guess when Simon imported the msg_test() function from openvpn/error.h wanted to leave those bits unchanged, for easier future adjustments... (which never happened).

Anyway, out it goes. Spring cleaning time. Compile tested with MinGW.

Your patch has been applied to the master branch.

commit 6d54d7ca5d32ebd830298b303a1146365fb35bbc

Author: Frank Lichtenheld
Date:   Sun Apr 19 15:39:41 2026 +0200
     tapctl: Remove unused function dont_mute

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg36662.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: tapctl: Remove unused function dont_mute
......................................................................

tapctl: Remove unused function dont_mute

Identified by cppcheck.

Change-Id I87c40dc94035345add1162e5029e51288811cb09

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36662.html

---
M src/tapctl/error.h
M src/tapctl/main.c

2 files changed, 2 insertions(+), 11 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/15/1615/4

src/tapctl/error.h +2 -2
index 9632b2f..f9586dc 100644
@@ -109,11 +109,11 @@
     return (level & M_DEBUG_LEVEL) <= x_debug_level;
 }
 
-/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flags represent */
 static inline bool
 msg_test(unsigned int flags)
 {
-    return check_debug_level(flags) && dont_mute(flags);
+    return check_debug_level(flags);
 }
 
 #endif /* ifndef ERROR_H */
src/tapctl/main.c +0 -9
index 1d047dd..6a4a240 100644
@@ -686,15 +686,6 @@
 }
 
 
-bool
-dont_mute(unsigned int flags)
-{
-    UNREFERENCED_PARAMETER(flags);
-
-    return true;
-}
-
-
 void
 x_msg_va(const unsigned int flags, const char *format, va_list arglist)
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email )

Change subject: tapctl: Remove unused function dont_mute
......................................................................

tapctl: Remove unused function dont_mute

Identified by cppcheck.

Change-Id I87c40dc94035345add1162e5029e51288811cb09

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36662.html

---
M src/tapctl/error.h
M src/tapctl/main.c

2 files changed, 2 insertions(+), 11 deletions(-)
src/tapctl/error.h +2 -2
index 9632b2f..f9586dc 100644
@@ -109,11 +109,11 @@
     return (level & M_DEBUG_LEVEL) <= x_debug_level;
 }
 
-/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flags represent */
 static inline bool
 msg_test(unsigned int flags)
 {
-    return check_debug_level(flags) && dont_mute(flags);
+    return check_debug_level(flags);
 }
 
 #endif /* ifndef ERROR_H */
src/tapctl/main.c +0 -9
index 1d047dd..6a4a240 100644
@@ -686,15 +686,6 @@
 }
 
 
-bool
-dont_mute(unsigned int flags)
-{
-    UNREFERENCED_PARAMETER(flags);
-
-    return true;
-}
-
-
 void
 x_msg_va(const unsigned int flags, const char *format, va_list arglist)
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>